Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogurec firmware #13242

Merged
merged 38 commits into from
Jul 22, 2021
Merged

ogurec firmware #13242

merged 38 commits into from
Jul 22, 2021

Conversation

drhigsby
Copy link

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/ogurec/config.h Outdated Show resolved Hide resolved
drhigsby and others added 3 commits June 19, 2021 08:50
adjusted VID based on drashna's advice
@drhigsby drhigsby requested a review from drashna June 21, 2021 23:44
drhigsby added 5 commits June 23, 2021 14:58
ogurec was dack's idea, so to honor his involvement, this is his personal keymap for the project
russian characters did not copy/paste correctly
Since the PCB is reversible, I added LAYOUT_RIGHT and LAYOUT_LEFT to the ogurec.h file and adjusted the default keymaps accordingly
specified that the PCB is reversible
keyboards/ogurec/keymaps/dack/keymap.c Outdated Show resolved Hide resolved
keyboards/ogurec/keymaps/dack/keymap.c Outdated Show resolved Hide resolved
keyboards/ogurec/keymaps/dack/keymap.c Outdated Show resolved Hide resolved
keyboards/ogurec/keymaps/dack/keymap.c Outdated Show resolved Hide resolved
keyboards/ogurec/keymaps/dack/keymap.c Outdated Show resolved Hide resolved
keyboards/ogurec/keymaps/dack/keymap.c Outdated Show resolved Hide resolved
drhigsby and others added 6 commits June 27, 2021 20:13
based on drashna's input

Co-authored-by: Drashna Jaelre <drashna@live.com>
based on drashna's input

Co-authored-by: Drashna Jaelre <drashna@live.com>
based on drashna's input

Co-authored-by: Drashna Jaelre <drashna@live.com>
based on drashna's input

Co-authored-by: Drashna Jaelre <drashna@live.com>
based on drashna's input

Co-authored-by: Drashna Jaelre <drashna@live.com>
based on drashna's input

Co-authored-by: Drashna Jaelre <drashna@live.com>
@drhigsby drhigsby requested a review from drashna June 28, 2021 03:30
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need matching changes to keymaps too.

keyboards/ogurec/ogurec.h Outdated Show resolved Hide resolved
keyboards/ogurec/ogurec.h Outdated Show resolved Hide resolved
keyboards/ogurec/ogurec.h Outdated Show resolved Hide resolved
keyboards/ogurec/ogurec.h Outdated Show resolved Hide resolved
drhigsby and others added 8 commits July 7, 2021 16:02
comitting drashna's suggested changes

Co-authored-by: Drashna Jaelre <drashna@live.com>
comitting drashna's suggested changes

Co-authored-by: Drashna Jaelre <drashna@live.com>
comitting drashna's suggested changes

Co-authored-by: Drashna Jaelre <drashna@live.com>
comitting drashna's suggested changes

Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team July 20, 2021 04:00
keyboards/ogurec/rules.mk Outdated Show resolved Hide resolved
keyboards/ogurec/readme.md Outdated Show resolved Hide resolved
keyboards/ogurec/readme.md Outdated Show resolved Hide resolved
drhigsby and others added 4 commits July 20, 2021 08:28
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
changed dack's keymap to be the default
changed default_left to left
changed default_right to right
updated the readme's accordingly
@drhigsby drhigsby requested a review from fauxpark July 20, 2021 17:39
drhigsby added 4 commits July 20, 2021 10:41
I really have no idea what I'm doing
still has compiling errors
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .lnk file.

keyboards/ogurec/rules.mk Outdated Show resolved Hide resolved
removed layout call in rules.mk
added dack's keymap back in
renamed layout macro
keyboards/ogurec/left_pm/readme.md Outdated Show resolved Hide resolved
keyboards/ogurec/left_pm/readme.md Outdated Show resolved Hide resolved
drhigsby and others added 2 commits July 21, 2021 15:40
committing fauxpark's suggestion

Co-authored-by: Ryan <fauxpark@gmail.com>
committing fauxpark's suggestion

Co-authored-by: Ryan <fauxpark@gmail.com>
@drhigsby drhigsby requested a review from fauxpark July 21, 2021 22:42
@@ -0,0 +1,3 @@
# Dack's Ogurec Keymap

This is Dack's personal ogurec keymap and it is for left-sided PM placement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just by the way, if you want to make this keymap unavailable to build for right_pm you can move it to another keymaps/ folder under left_pm.

@fauxpark fauxpark requested a review from a team July 22, 2021 03:15
@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks

@drashna drashna merged commit 336c8d3 into qmk:master Jul 22, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 22, 2021
* qmk/develop: (141 commits)
  Implement GPIO abstraction for atsam (qmk#13567)
  [Keyboard][Bug] Add timer_avr to includes for broken builds (qmk#13641)
  [Keyboard] adds new revision: dztech/dz60rgb/v2_1 (qmk#13636)
  [Keyboard] Fixing info.json for h0oni/hotduck (qmk#13640)
  [Keyboard] Ymd40v2new layouts and fixed per-switch backlight (qmk#13622)
  [Bug] Develop - DC01 left (qmk#13597)
  [Keyboard] Fix clawsome/hatchback and reviung5 compile issues (qmk#13607)
  [Keyboard] add ogurec (qmk#13242)
  [Keyboard] Add Durgod Taurus K310 keyboard (qmk#12314)
  [Keyboard] Updated keyboard & keymaps (qmk#12667)
  [Keyboard] add SPRH keyboard (qmk#12999)
  Retain brightness with lighting layers (qmk#13025)
  [Keyboard] Add keypad Satxri6key (qmk#13423)
  [Keyboard] Initial Tron Guy Labs keyboard implementation. (qmk#13438)
  [Keyboard] Add Ristretto Keyboard (qmk#13479)
  [Keyboard] New Keyboard - OBE (qmk#13545)
  [Keyboard] Add personal planck keymap (qmk#13635)
  [Keymap] narze/xd004 (qmk#13634)
  [Keyboard] Add h0oni hotduck keyboard (qmk#13609)
  Fix API generation failure caused by GRS-70EC (qmk#13631)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants